[pull] main from Kilo-Org:main #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the inline completion provider suggests text that adds to the current line (suggestion doesn't start with newline), only show the first line. VSCode will request the rest on subsequent completions. The full suggestion is shown when: - The suggestion starts with a newline (inserting a new line) - The current line is only whitespace (cursor on empty/indented line) This improves the UX by not overwhelming users with multi-line suggestions when they're typing in the middle of existing code.
When at the start of a line (only whitespace before cursor), show only the first line if the suggestion is 3 or more lines. This provides a better UX by showing smaller chunks that can be accepted incrementally. - Added countLines() helper function - Updated shouldShowOnlyFirstLine() to check line count when at start of line - Added comprehensive tests for the new behavior
…o findMatchingSuggestion - Add applyFirstLineOnlyIfNeeded() helper function - Apply first-line truncation in findMatchingSuggestion for all match types - Remove prefix parameter from stringToInlineCompletions - Update tests to reflect the new location of the logic
- Add applyFirstLineOnly() function that transforms findMatchingSuggestion results - findMatchingSuggestion() now returns raw (non-truncated) multi-line suggestions - Apply transformation at call sites in provideInlineCompletionItems_Internal - Update tests to reflect the separation of concerns - ghost-provider-tester can now see full suggestions without truncation
feat: show only first line of completion when adding to current line
* feat(cli): add ESC key as alternative to cancel streaming tasks * Fix tests
Show actual error instead of generic one
…ing) (#4416) * Fix memory leaks in CLI * Fix review notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )